[PATCH] D56528: [SEH] [ARM64] Retrieve the frame pointer from SEH funclets

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 9 18:51:57 PST 2019


efriedma added inline comments.


================
Comment at: lib/Target/AArch64/AArch64FrameLowering.cpp:927
+    if (F.hasPersonalityFn()) {
+      PerFn = dyn_cast<Function>(F.getPersonalityFn()->stripPointerCasts());
+      Per = classifyEHPersonality(PerFn);
----------------
The casting/stripPointerCasts/hasPersonalityFn is unnecessary here, I think; llvm::classifyEHPersonality will do it for you.

Checking the personality here seems a little awkward, but I guess it works.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56528/new/

https://reviews.llvm.org/D56528





More information about the llvm-commits mailing list