[PATCH] D56234: [lldb-server] Add unnamed pipe support to PipeWindows

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 9 15:37:51 PST 2019


zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.

This looks much nicer with the `pipe_t` type.



================
Comment at: source/Host/posix/PipePosix.cpp:70
+PipePosix::PipePosix(lldb::pipe_t read, lldb::pipe_t write)
+    : m_fds{(int)read, (int)write} {}
 
----------------
I don't think you need the cast, since the type is already int.  (Some compilers will warn if you cast something to its own type).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56234/new/

https://reviews.llvm.org/D56234





More information about the llvm-commits mailing list