[PATCH] D55625: [Intrinsic] Unsigned Fixed Point Multiplication Intrinsic

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 9 14:04:05 PST 2019


RKSimon added inline comments.


================
Comment at: llvm/test/CodeGen/X86/umul_fix.ll:32
+
+define i64 @func2(i64 %x, i64 %y) {
+; X64-LABEL: func2:
----------------
nounwind


================
Comment at: llvm/test/CodeGen/X86/umul_fix.ll:213
+
+define i64 @func5(i64 %x, i64 %y) {
+; X64-LABEL: func5:
----------------
nounwind


================
Comment at: llvm/test/CodeGen/X86/umul_fix.ll:262
+
+define <4 x i32> @vec2(<4 x i32> %x, <4 x i32> %y) nounwind {
+; X64-LABEL: vec2:
----------------
Can't you keep the vector codegen from scalarizing? See many of the other TargetLowering::expand* instructions which check for legal/custom vector operations before unrolling.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55625/new/

https://reviews.llvm.org/D55625





More information about the llvm-commits mailing list