[PATCH] D56501: [WebAssembly] Add unimplemented-simd128 subtarget feature

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 9 13:41:19 PST 2019


aheejin added a comment.

(We talked in person and decided not to make simd feature depend on signext)

Nice! Can we have a comment on the code why we are doing that? Basically what we've talked about - SIMD implementation needs `signext_inreg` for clean implementation but that doesn't mean we require signext feature to enable simd feature, so we are doings this blah blah

And I think we should revert the test changes now?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56501/new/

https://reviews.llvm.org/D56501





More information about the llvm-commits mailing list