[PATCH] D56320: [mips] Optimize shifts for types larger than GPR size (mips2/mips3)

[Simon Atanasyan via Phabricator via llvm-commits]

atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.

LGTM with a couple of nits



================
Comment at: lib/Target/Mips/MipsISelLowering.cpp:2443
+
+  if (!(Subtarget.hasMips4() || Subtarget.hasMips32())) {
+    SDVTList VTList = DAG.getVTList(VT, VT);
----------------
clang-format the `if` block please


================
Comment at: lib/Target/Mips/MipsISelLowering.cpp:4380
+  // have the same condition operand. On machines which don't have
+  // conditional-move instrution, it reduces unnecessary branch instructions
+  // which are result of using two diamond patterns that are result of two
----------------
s/instrution/instruction/


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56320/new/

https://reviews.llvm.org/D56320