[PATCH] D55720: [Intrinsic] Signed Fixed Point Saturation Multiplication Intrinsic
Leonard Chan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 9 13:08:05 PST 2019
leonardchan added a comment.
In D55720#1336355 <https://reviews.llvm.org/D55720#1336355>, @ebevhan wrote:
> Nothing sticks out to me, so I think it looks good. Hard to tell if there are any sneaky edge cases in the lowering steps, though.
>
> Maybe you should rebase this on top of the unsigned patch, since they're touching all the same places. Or are you waiting for it to land?
Yeah, I figure it would be better to submit these as separate patches since they're still technically independent of each other and ideally makes it easier for it to review.
@bjope @craig.topper @RKSimon Any comments on this patch?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55720/new/
https://reviews.llvm.org/D55720
More information about the llvm-commits
mailing list