[PATCH] D47073: Document and Enforce new Host Compiler Policy

[JF Bastien via Phabricator via llvm-commits]

jfb added inline comments.


================
Comment at: cmake/modules/CheckCompilerVersion.cmake:29
+                "(minimum version is GCC ${GCC_MIN}). Compiler version checking"
+                " can be ignored with the cmake option LLVM_IGNORE_HOST_VERSION_CHECK.")
+      elseif(CMAKE_CXX_COMPILER_VERSION VERSION_LESS GCC_MIN)
----------------
Macro name is still wrong :)


================
Comment at: cmake/modules/CheckCompilerVersion.cmake:43
+                "checking can be ignored with the cmake option "
+                "LLVM_IGNORE_HOST_VERSION_CHECK.")
+      elseif(CMAKE_CXX_COMPILER_VERSION VERSION_LESS CLANG_MIN)
----------------
Wrong here too.


================
Comment at: cmake/modules/CheckCompilerVersion.cmake:76
       endif()
+    elseif(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang")
+      if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS APPLECLANG_MIN
----------------
Probably better to have this next to the clang code, so they don't diverge.


================
Comment at: cmake/modules/CheckCompilerVersion.cmake:82
+                "checking can be ignored with the cmake option "
+                "LLVM_IGNORE_HOST_VERSION_CHECK.")
+      elseif(CMAKE_CXX_COMPILER_VERSION VERSION_LESS APPLECLANG_MIN)
----------------
Name wrong.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D47073/new/

https://reviews.llvm.org/D47073