[PATCH] D56327: [PGO] Use SourceFileName rather module name in PGOFuncName
Rong Xu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 9 12:19:41 PST 2019
xur added a comment.
@kristina: This patch does not functionally change anything in current code base. We think this patch makes more sense than the original one (which also contributed by us)
Current code works fine (as all the callers to getPGOFuncName() are before LTO). Tests for stripping behavior is already in the test suite.
It will break once that functions is called in LTO or after LTO with unknown function error. This will show in patch here https://reviews.llvm.org/D54175.
I cannot write a new test for this as there is currently no caller from LTO or passes after LTO.
If I cannot land this patch alone, I have to move it to D54175 <https://reviews.llvm.org/D54175>.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56327/new/
https://reviews.llvm.org/D56327
More information about the llvm-commits
mailing list