[PATCH] D56433: [NewPM] Port tsan

[Dan Liew via Phabricator via llvm-commits]

delcypher added a comment.

@philip.pfaffe

> `__tsan_init` is external to generated TSan code (it lives in the TSan runtime), where as `tsan.module_ctor()` was in the same module. Perhaps dyld doesn't like calling functions external to the module directly.

I've confirmed this with the authors of dyld. The indirection via `tsan.module_ctor()` is necessary for Darwin platforms because dyld requires that the global constructors for an image (module) point to functions in the same `.TEXT` segment as that image.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56433/new/

https://reviews.llvm.org/D56433