[PATCH] D47073: Document and Enforce new Host Compiler Policy

[JF Bastien via Phabricator via llvm-commits]

jfb added a comment.

You'll also need to treat AppleClang different from Clang, since version numbering is different.

A good list of versions is: https://en.wikipedia.org/wiki/Xcode#Latest_versions
3 years puts you at AppleClang 7.3.0, and 1.5 years at 8.1.0.



================
Comment at: cmake/modules/CheckCompilerVersion.cmake:27
+                "(minimum version is GCC ${GCC_MIN}). Compiler version checking"
+                " can be ignored with the cmake option LLVM_IGNORE_HOST_VERISON_CHECK.")
+      elseif(CMAKE_CXX_COMPILER_VERSION VERSION_LESS GCC_MIN)
----------------
The name of the macro is horrible wrong here. I like misdirection ;)


================
Comment at: cmake/modules/CheckCompilerVersion.cmake:41
+                "checking can be ignored with the cmake option "
+                "LLVM_IGNORE_HOST_VERISON_CHECK.")
+      elseif(CMAKE_CXX_COMPILER_VERSION VERSION_LESS CLANG_MIN)
----------------
Ditto


================
Comment at: docs/CMake.rst:576
 
+**LLVM_IGNORE_HOST_COMPILER_VERSION_CHECK**:BOOL
+  If enabled, the CMake checks for Clang and GCC minimum host compiler versions
----------------
Update name.


================
Comment at: docs/GettingStarted.rst:290
+deprecation. In order to assist developers to properly prepare their
+environments, a CMake warning will be emitted for any older than 1.5 years from
+the previous LLVM release's branch date.
----------------
I think you want to update this text as in the comment you just updated.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D47073/new/

https://reviews.llvm.org/D47073