[PATCH] D56091: [WebAssembly] Don't add IMPLICIT_DEFs in PrepareForLiveIntervals

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 9 10:33:05 PST 2019


dschuff added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyPrepareForLiveIntervals.cpp:61
+  // We're now ready to run the LiveIntervals analysis again.
   MF.getProperties().set(MachineFunctionProperties::Property::TracksLiveness);
 
----------------
This (setting the MachineFunctionProperty) is now the only thing that this pass does. Do we really need all the pass boilerplate just to do that? e.g. can we stick it at the beginning of OptimizeLiveIntervals or RegisterColoring or wherever we actually need it? 


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56091/new/

https://reviews.llvm.org/D56091





More information about the llvm-commits mailing list