[PATCH] D56272: [llvm-symbolizer] Add support for specifying input addresses on the command-line

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: test/tools/llvm-symbolizer/basic.s:11-13
+# RUN: echo 0xa > %t1.input
+# RUN: echo 0xb >> %t1.input
+# RUN: llvm-symbolizer --obj=%t.o < %t1.input | FileCheck %s
----------------
jhenderson wrote:
> ruiu wrote:
> > Why don't you do
> > 
> >   echo "0xa 0xb" | llvm-symbolizer ...
> > 
> > ?
> When fed in via stdin, each input needs to be on a new line. I'm not sure I know a way to do this with a single echo command.
In lld we do like this:

  echo -e "0xa\n0xb\n" | ...



Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56272/new/

https://reviews.llvm.org/D56272