[PATCH] D56272: [llvm-symbolizer] Add support for specifying input addresses on the command-line

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: test/tools/llvm-symbolizer/basic.s:11-13
+# RUN: echo 0xa > %t1.input
+# RUN: echo 0xb >> %t1.input
+# RUN: llvm-symbolizer --obj=%t.o < %t1.input | FileCheck %s
----------------
Why don't you do

  echo "0xa 0xb" | llvm-symbolizer ...

?


================
Comment at: tools/llvm-symbolizer/llvm-symbolizer.cpp:202-204
+    while (true) {
+      if (!fgets(InputString, sizeof(InputString), stdin))
+        break;
----------------
Now it is more straightforward to move `fgets` inside the `while` condition?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56272/new/

https://reviews.llvm.org/D56272