[PATCH] D55444: AMDGPU: Fix DPP combiner

[Pykhtin, Valery via llvm-commits]

Well, yes, but the pass being fixed isn't enabled by default and isn't used other than in RADV yet. There is no strong reasons not to submit it as this is a fix. 

-----Original Message-----
From: Roman Lebedev [mailto:lebedev.ri at gmail.com] 
Sent: Wednesday, January 9, 2019 6:02 PM
To: reviews+D55444+public+c427eaae76475471 at reviews.llvm.org; Valery Pykhtin via Phabricator
Cc: Pykhtin, Valery; cwabbott0 at gmail.com; Arsenault, Matthew; Liu, Yaxun (Sam); Salinas, David; Voicu, Alexandru; wei.ding2 at amd.com; llvm-commits at lists.llvm.org; Tamazov, Artem; Nicolai Haehnle; aakanksha555 at gmail.com; Jan Vesely; nemanja.i.ibm at gmail.com; Rodgers, Gregory; tpr.llvm at botech.co.uk; Stuttard, David; Zhuravlyov, Konstantin; Tye, Tony; Henning, Neil; Chandler Carruth
Subject: Re: [PATCH] D55444: AMDGPU: Fix DPP combiner

On Wed, Jan 9, 2019 at 4:59 PM Valery Pykhtin via Phabricator via
llvm-commits <llvm-commits at lists.llvm.org> wrote:
>
> vpykhtin added a comment.
>
> Hi Connor,
>
> I submitted my latest patch, the pass is still disabled by defaul. Can you please run the RADV tests now (with the pass manually enabled)?
That is not how review process in llvm works.
It doesn't look like this got reviewed, and if so, normally this
should be reverted.

> Repository:
>   rL LLVM
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D55444/new/
>
> https://reviews.llvm.org/D55444
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits