[PATCH] D56123: [llvm-objdump] - Print symbol addressed when dumping disassembly output (-d)

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

In D56123#1343558 <https://reviews.llvm.org/D56123#1343558>, @jhenderson wrote:

> LGTM too. Not that I'm saying you should change it, as I don't know how complex it would be, but perhaps an alternative to consider might have been to disassemble the first zeroes after a symbol, even without -z. Something like this:
>
>   foo:
>   10: 00 00
>   ...
>   bar:
>   40: 00 00
>   ...
>
>
> I'm not sure how desirable that is versus the alternative though (really, I'm not sure I see much benefit to the behaviour of not disassembling zeroes, but that's just me).


I am definitely not against of further tweaking of the -z/no -z  behavior, but I think printing the symbol address (this patch) can and should be an independent thing.
Skipping/not-skipping any zeroes is a heuristic logic that might change and it better to reduce/eliminate/not introduce any dependencies/assumptions here I believe.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56123/new/

https://reviews.llvm.org/D56123