[PATCH] D56422: gn build: Use "git rev-parse --git-dir" to discover the path to the .git directory.
Nico Weber via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 9 06:07:28 PST 2019
thakis accepted this revision.
thakis added inline comments.
This revision is now accepted and ready to land.
================
Comment at: llvm/utils/gn/build/write_vcsrevision.py:35
if os.path.isdir(os.path.join(LLVM_DIR, '.svn')):
print('SVN support not implemented', file=sys.stderr)
----------------
should this use `exists()` too to be consistent with line 38?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56422/new/
https://reviews.llvm.org/D56422
More information about the llvm-commits
mailing list