[PATCH] D56434: [AMDGPU] Fix dwordx3/southern-islands failures.
Neil Henning via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 9 05:06:49 PST 2019
sheredom marked 4 inline comments as done.
sheredom added inline comments.
================
Comment at: lib/Target/AMDGPU/AMDGPUSubtarget.h:821-823
+ bool hasDwordx3LoadStores() const {
+ return getGeneration() > AMDGPUSubtarget::SOUTHERN_ISLANDS;
+ }
----------------
arsenm wrote:
> sheredom wrote:
> > arsenm wrote:
> > > return CIInsts?
> > Not sure what you mean here?
> It's better to use the subtarget feature for the instruction set, rather than rely on the generation here. The closest one we already have is ci-insts
Oh I didn't know about that - good idea!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56434/new/
https://reviews.llvm.org/D56434
More information about the llvm-commits
mailing list