[PATCH] D56482: DO NOT SUBMIT. Draft for guidelines on using Phabricator.

Wed Jan 9 02:45:57 PST 2019

kristina added a comment.

In D56482#1350854 <https://reviews.llvm.org/D56482#1350854>, @MyDeveloperDay wrote:

> $ ./validate_check.py --rst ../../../../../docs/Phabricator.rst
>  Checking ..\..\..\..\..\docs\Phabricator.rst...
>  warning: line 97 multiple blank lines
>  warning: line 166 is in excess of 80 characters (82) : as it will retrieve reviewers, the ``Differential Revision``, etc from the review
>  ...
>  warning: line 175 contains double spaces
>  warning: line 188 is in excess of 80 characters (97) : The first command will take the latest version of the reviewed patch and apply it to the working
>  ...
>  warning: line 194 is in excess of 80 characters (111) : This presumes that the git repository has been configured as described in :ref:`developers-work-with-git-svn`.
>  ...
>  warning: line 203 multiple blank lines
>  warning: line 205 is in excess of 80 characters (84) : current ``master`` and will create a commit corresponding to ``D<Revision>`` with a
>  ...
>  warning: line 208 is in excess of 80 characters (85) : Check you are happy with the commit message and amend it if necessary. Now switch to
>  ...
>  warning: line 218 multiple blank lines
>  warning: line 219 multiple blank lines

I only added a section, all the warnings are from existing bits below. Not sure if it's a good idea to reformat it as part of the diff as it will make it harder to see the added section. Can do it afterwards but that's what's currently being used to generate documentation.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56482/new/

https://reviews.llvm.org/D56482