[PATCH] D56379: GlobalISel: Implement fewerElementsVector for constants

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 8 22:53:10 PST 2019


arsenm added a comment.

In D56379#1348785 <https://reviews.llvm.org/D56379#1348785>, @aemerson wrote:

> This is strange. G_CONSTANT isn't supposed to be able to splat the constant into a vector, so this is an oversight in the MachineVerifier for not catching this case.
>
> Constant vectors are handled in the IRTranslator as G_BUILD_VECTORs of the constant element values. Sorry about the confusion.


They aren't handled this way in the MachineIRBuilder. I would prefer it if G_CONSTANT did splat, since I always found this extremely annoying in SelectionDAG


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56379/new/

https://reviews.llvm.org/D56379





More information about the llvm-commits mailing list