[PATCH] D56423: gn build: Copy file permissions from input file in configure_file() emulation.

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 8 19:54:42 PST 2019


phosek added inline comments.


================
Comment at: llvm/utils/gn/build/write_cmake_config.py:105
 
+    os.chmod(args.output, os.stat(args.input).st_mode & 0777)
+
----------------
Shouldn't this be inside the `if` block so the permissions are only changed if file is actually written?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56423/new/

https://reviews.llvm.org/D56423





More information about the llvm-commits mailing list