rL350671: [PGO] Use SourceFileName rather module name in PGOFuncName

Kristina Brooks via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 8 17:12:09 PST 2019


Hi,

I slightly screwed up using Audit but do you mind addressing the issues from pre-commit
review:

kristina raised a concern with this commit.
kristina added an auditor: kristina.
kristina added a comment.

Unaddressed issues in pre-commit review.

/llvm/trunk/lib/ProfileData/InstrProf.cpp:256 C cast. And again using an stdint type seems questionable, even if you
insist on an unsigned type, `unsigned int` would work (I still think this is not a perfect solution) better unless you
need exactly 32 bits, I've tried to mention it in pre-commit review.
/llvm/trunk/lib/ProfileData/InstrProf.cpp:255 Don't change the style, use assignment-construction. Besides this is
inconsistent with the rest of the patch.

Users:
  xur (Author)
  kristina (Auditor)

https://reviews.llvm.org/rL350671



-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3992 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190109/c7ab1355/attachment.bin>


More information about the llvm-commits mailing list