[PATCH] D56401: [WebAssembly] Fix updating/moving DBG_VALUEs in RegStackify

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyRegStackify.cpp:498
+      if (!MI->isDebugValue() || MI->getParent() != &MBB)
+        continue;
+      // Scan backwards to find very next operand with isDef set. If instruction
----------------
aheejin wrote:
> So by this point it looks like you assume `Op` is a use and not a def, right? Maybe you should also add a clause to exclude defs as well, like
> ```
> if (Op.isDef())
>   continue;
> ```
Oh I meant to delete this comment and I didn't. If you use `MRI.def_operands(Reg))` at the top of the loop, you wouldn't need this. Sorry


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56401/new/

https://reviews.llvm.org/D56401