[PATCH] D55740: Fix sanitizer tool list used to generate sanitizer_common tests to be up-to-date.

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: test/sanitizer_common/CMakeLists.txt:18
+    if (COMPILER_RT_HAS_${SANITIZER_TOOL_UPPER})
+      list(APPEND SUPPORTED_TOOLS ${SANITIZER_TOOL})
+    endif()
----------------
# Remove: "if (NOT (ANDROID OR WINDOWS))"
# Create the list
# Print the list
#  for windows and android:
  - replace the list and with hardcoded one
  - print the new list and with some FIXME warning about this replacement


================
Comment at: test/sanitizer_common/TestCases/symbolize_stack.cc:6
+// FIXME(dliew): Make this test work with the other sanitizers.
+// UNSUPPORTED: darwin && (lsan || tsan || ubsan)
+
----------------
why is this not XFAIL? 


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55740/new/

https://reviews.llvm.org/D55740