[PATCH] D56460: [X86] Disable DomainReassignment pass when AVX512BW is disabled to avoid injecting VK32/VK64 references into the MachineIR

[Craig Topper via Phabricator via llvm-commits]

craig.topper created this revision.
craig.topper added reviewers: RKSimon, spatel.

This pass replaces GR8/GR16/GR32/GR64 with their equivalent sized mask register classes. But VK32/VK64 aren't legal without AVX512BW. Apparently this mostly appears to work if the register coalescer is able to remove the VK32/VK64 register class reference. Or if we don't ever spill it. But there's no guarantee of that.

Another Intel employee managed to trigger a crash due to this with ISPC. Unfortunately, I've lost the test case he sent me at the time. I'm trying to get him to reproduce it for me. I'd like to get this in before 8.0 branches since its a little scary.

The regressions here are unfortunate, but I think we can make some improvements to DAG combine, load folding, etc. to fix them. Just not sure if we can get that done for 8.0.


https://reviews.llvm.org/D56460

Files:
  lib/Target/X86/X86DomainReassignment.cpp
  test/CodeGen/X86/avx512-intrinsics-fast-isel.ll
  test/CodeGen/X86/avx512-mask-op.ll
  test/CodeGen/X86/avx512vl-intrinsics.ll
  test/CodeGen/X86/vec_floor.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56460.180760.patch
Type: text/x-patch
Size: 67843 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190108/106e46ff/attachment-0001.bin>