[PATCH] D56434: [AMDGPU] Fix dwordx3/southern-islands failures.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 8 15:13:25 PST 2019


arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUSubtarget.h:821-823
+  bool hasDwordx3LoadStores() const {
+    return getGeneration() > AMDGPUSubtarget::SOUTHERN_ISLANDS;
+  }
----------------
sheredom wrote:
> arsenm wrote:
> > return CIInsts?
> Not sure what you mean here?
It's better to use the subtarget feature for the instruction set, rather than rely on the generation here. The closest one we already have is ci-insts


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56434/new/

https://reviews.llvm.org/D56434





More information about the llvm-commits mailing list