[PATCH] D56255: [ARM] Size reduce teq to eors

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 8 11:54:27 PST 2019


efriedma added a comment.

> The mir test isn't producing the IT block, and I'm unsure why and how to get this to work

Run your IR testcase with "llc -stop-before=unpack-mi-bundles"; that should give you MIR in the form the second run of Thumb2SizeReduction will see it.



================
Comment at: lib/Target/ARM/Thumb2SizeReduction.cpp:924
+    MO.setIsKill(false);
+    MO.setIsDef(true);
+    MIB.add(MO);
----------------
Maybe also `setIsDead(true)`?  Probably doesn't make much difference this late, but probably better to be consistent.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56255/new/

https://reviews.llvm.org/D56255





More information about the llvm-commits mailing list