[PATCH] D56448: [PPC64] Fix RelType in checkInt and checkAlignment diagnsotics.

Tue Jan 8 11:41:22 PST 2019

sfertile marked an inline comment as done.
sfertile added inline comments.

================
Comment at: ELF/Arch/PPC64.cpp:615-617
+  // We need to save the original relocation type to use in diagnostics, and
+  // use the original type to determine if we should toc-optimize the
+  // instructions being relocated.
----------------
ruiu wrote:
> Where are you using this variable to check whether toc-optimize should be done or not?
I'm not using the new variable since the call to `isTocOptType` comes before we map the relocations to an addr16 type and `Type` is still the original type.  With the comment I'm trying to convey there is an explicit dependency between `isTocOptType` and `toAddr16Rel`. 

Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56448/new/

https://reviews.llvm.org/D56448