[PATCH] D53540: [COFF, ARM64] Implement support for SEH extensions __try/__except/__finally
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 8 11:39:37 PST 2019
efriedma added inline comments.
================
Comment at: lib/Target/AArch64/AArch64AsmPrinter.cpp:713
+ MovZ.addOperand(Hi_MCSym);
+ MovZ.addOperand(MCOperand::createImm(0));
+ EmitToStreamer(*OutStreamer, MovZ);
----------------
I think this "createImm" is wrong; should be 16. (It probably doesn't show up in the printed assembly, but I think it affects the encoding.)
================
Comment at: lib/Target/AArch64/AArch64RegisterInfo.cpp:271
+ if (MFI.hasVarSizedObjects() || (MF.hasEHFunclets() &&
+ !MF.hasLocalEscape())) {
if (needsStackRealignment(MF))
----------------
This can't be correct in general... in cases involving stack realignment, it's impossible to generate code without a base pointer.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D53540/new/
https://reviews.llvm.org/D53540
More information about the llvm-commits
mailing list