[PATCH] D56428: [SelectionDAGBuilder] Respect getBooleanContents in copies to VRegs

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 8 11:30:36 PST 2019


tlively added a comment.

One question I have about this is whether BooleanContents should apply to *all* i1 values, which is what this patch assumes, or whether it should only apply to certain i1 values that are logically Boolean because they are the result of a setcc or similar. If BooleanContents should only apply to some i1s, this fix is overly conservative.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56428/new/

https://reviews.llvm.org/D56428





More information about the llvm-commits mailing list