[PATCH] D56433: [NewPM] Port tsan

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc added a comment.

Only one real question... Worried a little about the total cost here, but the code looks fine.



================
Comment at: llvm/lib/Transforms/Instrumentation/ThreadSanitizer.cpp:88
 
 /// ThreadSanitizer: instrument the code in module to find races.
+struct ThreadSanitizer {
----------------
Similar documentation update as for msan?


================
Comment at: llvm/lib/Transforms/Instrumentation/ThreadSanitizer.cpp:179
 
 void ThreadSanitizer::initializeCallbacks(Module &M) {
   IRBuilder<> IRB(M.getContext());
----------------
There are a lot of functions here, including numerous loops... Is this really ok to do every function?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56433/new/

https://reviews.llvm.org/D56433