[PATCH] D54277: Move RedirectingFileSystem interface into header.

[Sam McCall via Phabricator via llvm-commits]

sammccall added a comment.

This looks reasonable to me, thanks! Just questions about what's exposed where.
(Apologies, was out for all of december and just got back)



================
Comment at: include/llvm/Support/VirtualFileSystem.h:496
+
+/// A single file or directory in the VFS.
+class Entry {
----------------
Entry and EntryKind don't seem to apply to anything other than RedirectingVFS, so I think they could be nested within RedirectingVFS or at least given names tying them to that class (rather than to VFS itself)


================
Comment at: include/llvm/Support/VirtualFileSystem.h:624
+class RedirectingFileSystem : public vfs::FileSystem {
+protected:
+  friend class VFSFromYamlDirIterImpl;
----------------
does this stuff need to be protected rather than private? I can't find any subclasses


================
Comment at: include/llvm/Support/VirtualFileSystem.h:750
 
+  const std::vector<YAMLVFSEntry> &getMappings() const { return Mappings; }
+
----------------
Unrelated/unused?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54277/new/

https://reviews.llvm.org/D54277