[PATCH] D56417: [gn build] Make sync_source_lists_from_cmake.py check that all LLVM unittests are present

Phabricator via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 8 07:20:59 PST 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rL350631: [gn build] Make sync_source_lists_from_cmake.py check that all LLVM unittests… (authored by nico, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D56417?vs=180571&id=180666#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56417/new/

https://reviews.llvm.org/D56417

Files:
  llvm/trunk/utils/gn/build/sync_source_lists_from_cmake.py


Index: llvm/trunk/utils/gn/build/sync_source_lists_from_cmake.py
===================================================================
--- llvm/trunk/utils/gn/build/sync_source_lists_from_cmake.py
+++ llvm/trunk/utils/gn/build/sync_source_lists_from_cmake.py
@@ -60,8 +60,7 @@
     # Matches e.g. |add_llvm_unittest_with_input_files|.
     unittest_re = re.compile(r'^add_\S+_unittest', re.MULTILINE)
 
-    # FIXME: Add 'llvm' here once it's complete.
-    checked = [ 'clang', 'lld' ]
+    checked = [ 'clang', 'lld', 'llvm' ]
     for c in checked:
         for root, _, _ in os.walk(os.path.join(c, 'unittests')):
             cmake_file = os.path.join(root, 'CMakeLists.txt')


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56417.180666.patch
Type: text/x-patch
Size: 679 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190108/499e3cfc/attachment.bin>


More information about the llvm-commits mailing list