[PATCH] D56434: [AMDGPU] Fix dwordx3/southern-islands failures.
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 8 04:48:16 PST 2019
arsenm added inline comments.
================
Comment at: lib/Target/AMDGPU/AMDGPUSubtarget.h:821-823
+ bool hasDwordx3LoadStores() const {
+ return getGeneration() > AMDGPUSubtarget::SOUTHERN_ISLANDS;
+ }
----------------
return CIInsts?
================
Comment at: lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:375-379
+ if (!STM.hasDwordx3LoadStores() && (Width == 3)) {
+ return false;
+ }
+
return Width <= 4;
----------------
I would merge these into just one return
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56434/new/
https://reviews.llvm.org/D56434
More information about the llvm-commits
mailing list