[PATCH] D56431: [llvm-objcopy] [COFF] Remove pointless Reader/Writer base classes. NFC.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 8 03:48:18 PST 2019
jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
LGTM. I have no issue with this, but I'd like @jakehehrlich to give his opinion as essentially it's a design choice as to how much the COFF structure of llvm-objcopy should match the ELF structure.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56431/new/
https://reviews.llvm.org/D56431
More information about the llvm-commits
mailing list