[PATCH] D54889: Fiber support for thread sanitizer

Dmitry Vyukov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 8 01:49:25 PST 2019


dvyukov added a comment.

In D54889#1349383 <https://reviews.llvm.org/D54889#1349383>, @dvyukov wrote:

> In D54889#1348716 <https://reviews.llvm.org/D54889#1348716>, @yuri wrote:
>
> > I improved test execution time. On my system I got following execution times (compared to original version of code):
> >
> > | compiler | current | fibers |
> > | -------- | ------- | ------ |
> > | gcc 8.2  | 100.0%  | 98.6%  |
> > | clang    | 112.4%  | 100.7% |
> > |
>
>
> "current" is compiler-rt HEAD with no local changes, or with the previous version of this change? This makes clang-compiled runtime 12% faster?
>  Were you able to reproduce the slowdown in  https://reviews.llvm.org/D54889#1343582 with the previous version of the fibers change? What slowdown did you get?


What exactly has changed wrt performance? I see some small tweaks, but I am not sure if they are the main reason behind the speedup or I am missing something important.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54889/new/

https://reviews.llvm.org/D54889





More information about the llvm-commits mailing list