[PATCH] D56406: Check for single use in cvt_f32_ubyte combine instead of ShrinkDemandedConstant

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 7 14:42:10 PST 2019

Previous message: [PATCH] D56406: Check for single use in cvt_f32_ubyte combine instead of ShrinkDemandedConstant
Next message: [PATCH] D56406: Check for single use in cvt_f32_ubyte combine instead of ShrinkDemandedConstant
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

fhahn added a comment.

Great thanks! IMO the caller of ShrinkDemandedConstant should make sure the demanded bits valid for all users, as the existing code in TargetLowering.cpp already should do.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56406/new/

https://reviews.llvm.org/D56406

Previous message: [PATCH] D56406: Check for single use in cvt_f32_ubyte combine instead of ShrinkDemandedConstant
Next message: [PATCH] D56406: Check for single use in cvt_f32_ubyte combine instead of ShrinkDemandedConstant
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list