[PATCH] D52803: [GISel]: Add support for CSEing continuously during GISel passes

[Kristof Beyls via Phabricator via llvm-commits]

kristof.beyls added a comment.

In D52803#1349005 <https://reviews.llvm.org/D52803#1349005>, @aditya_nandakumar wrote:

> By default the CSE is enabled during IRTranslator and Legalizer now (disable with -enable-cse-in-legalizer/irtranslator=0).


I naively wonder if unconditionally enabling a CSE optimization even at -O0 is going to lead to a poorer debug experience in some cases?

> I've also updated most tests (except some tests where it's not obvious what the test is doing where CSE is disabled).

If CSE should be enabled by default, I guess that we'll need to figure out what the tests are supposed to be doing so that there aren't many tests mainly testing non-default behaviour?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52803/new/

https://reviews.llvm.org/D52803