[PATCH] D55639: GlobalISel: Allow shift amount to be a different type
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 7 23:00:08 PST 2019
arsenm marked an inline comment as done.
arsenm added inline comments.
================
Comment at: include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h:115
+ if (isInstUnsupported({TargetOpcode::G_SHL, {DstTy, DstTy}}) ||
+ isInstUnsupported({TargetOpcode::G_ASHR, {DstTy, DstTy}}) ||
isInstUnsupported({TargetOpcode::G_CONSTANT, {DstTy}}))
----------------
aemerson wrote:
> Use the SrcTy here?
It's required to be the same, so I don't see the point? The problematic part is the shift amount src type, since there was no shift to begin with
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55639/new/
https://reviews.llvm.org/D55639
More information about the llvm-commits
mailing list