[PATCH] D55988: WIP: RegBankSelect: Support some more complex part mappings

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: include/llvm/CodeGen/GlobalISel/RegisterBankInfo.h:629
+  /// be inserted.
+  virtual unsigned getBreakDownCost(const ValueMapping &ValMapping) const {
+    return std::numeric_limits<unsigned>::max();
----------------
qcolombet wrote:
> I feel we miss a register bank in that prototype (what you'd referenced as CurBank).
I had this initially, but then discovered it will always be null. The array of banks is present in ValMapping


================
Comment at: lib/CodeGen/GlobalISel/RegBankSelect.cpp:209
+  assert(RepairPt.getNumInsertPoints() == 1 &&
+         "is it possible to have multiple?");
+
----------------
qcolombet wrote:
> Yes, if we repair a physical register. In practice I've never seen that happen.
An example would help, since handling this is what makes the more general handling more annoying


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55988/new/

https://reviews.llvm.org/D55988