[PATCH] D56426: gn build: Stop passing -o to ar.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc created this revision.
pcc added reviewers: phosek, thakis.

The -o flag means something different to ar than what appears to be
intended here. Also, llvm-ar doesn't accept the flag in this position.


Repository:
  rL LLVM

https://reviews.llvm.org/D56426

Files:
  llvm/utils/gn/build/toolchain/BUILD.gn


Index: llvm/utils/gn/build/toolchain/BUILD.gn
===================================================================
--- llvm/utils/gn/build/toolchain/BUILD.gn
+++ llvm/utils/gn/build/toolchain/BUILD.gn
@@ -51,7 +51,7 @@
       # Remove the output file first so that ar doesn't try to modify the
       # existing file.
       command =
-          "rm -f {{output}} && ar rcsDT {{arflags}} -o {{output}} {{inputs}}"
+          "rm -f {{output}} && ar rcsDT {{arflags}} {{output}} {{inputs}}"
     }
     description = "AR {{output}}"
     outputs = [


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56426.180604.patch
Type: text/x-patch
Size: 548 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190108/5cd938b0/attachment.bin>