[PATCH] D56094: [WebAssembly] Fix stack pointer store check in RegStackify

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added a comment.

@sunfish By the way, when we check interfering read/write/sideeffect/stackpointer here <https://github.com/llvm-mirror/llvm/blob/4f496b838baffd2cd95e80b4a85b9e523ef6d070/lib/Target/WebAssembly/WebAssemblyRegStackify.cpp#L368-L390> to figure out if the given instruction is safe to move, all calls are assumed to touch the stack pointer <https://github.com/llvm-mirror/llvm/blob/4f496b838baffd2cd95e80b4a85b9e523ef6d070/lib/Target/WebAssembly/WebAssemblyRegStackify.cpp#L140-L141>. But aren't all calls supposed to restore stack pointer before they return? What is the reason we can't move a call over another call because of interfering stack pointer?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56094/new/

https://reviews.llvm.org/D56094