[PATCH] D56419: [gn build] Move .gn file to the root of the monorepo

Kristina Brooks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 7 17:46:14 PST 2019


kristina added a comment.

In D56419#1349092 <https://reviews.llvm.org/D56419#1349092>, @thakis wrote:

> In D56419#1349087 <https://reviews.llvm.org/D56419#1349087>, @kristina wrote:
>
> > I'm neutral on the issue but I would urge Nico to really think this through, lashback from some major downstream Linux distro vendors last time was pretty nasty, including flat out dropping Clang/LLVM support if CMake became a second class citizen. Is rehashing the same thing again worth it? Consider that a lot of people, no matter what you say will see it as GN slowly creeping in to replace CMake, not many are familiar with it outside Google or Chromium/Skia contributors.
>
>
> I'd like to reiterate that this patch does not change anything about LLVM's build system situation. CMake is the supported build system. GN is 100% unsupported (as I've added as a comment to the file as I moved it over). I do not intend to push for changing this.


Again, I'm not against it, I only raised a point, it's not me you have to reassure. I'll emphasize what I said before - "//Consider that a lot of people, no matter what you say will see it as GN slowly creeping in to replace CMake//".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56419/new/

https://reviews.llvm.org/D56419





More information about the llvm-commits mailing list