[PATCH] D56419: [gn build] Move .gn file to the root of the monorepo

Brian Rzycki via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 7 16:28:10 PST 2019


brzycki added a comment.

> This is not changing. The first line in the added file here is: "# LLVM's GN build is unsupported, see llvm/utils/gn/README.rst for details." Is that not clear enough? I'm happy to repeat that line 100 times and add another 100 lines whitespace to make it more obvious.

If it is unsupported it should not be at the top-level. If it is moved to the top-level is should be supported. The playground for experimental and unsupported tools is utils/.

>   I don't see the downside of adding a hidden file at the toplevel yet.

The change promotes an unsupported, parallel, build system to the top of LLVM. It's precisely the situation I and others who spoke up on llvm-dev were trying to avoid.

> I'd like to point out that there's no interest from Google in this.

So why make the change at all then if so few people are even using gn at all?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56419/new/

https://reviews.llvm.org/D56419





More information about the llvm-commits mailing list