[PATCH] D56419: [gn build] Move .gn file to the root of the monorepo

Brian Rzycki via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 7 16:03:44 PST 2019


brzycki added a comment.

I am strongly against this commit. @thakis when this was discussed on llvm-dev the original proposal was the compromise of placing .gn in utils to signify that it was not the default, recommended, method to build LLVM.  With this change LLVM will truly have two, parallel build systems once again.

In my opinion making the invocation of gn less cumbersome for a handful of Google developers does not justify the significance of having two build systems at the top level.

Can't this simply be solved with the following scripting?

  git clone monorepo $DIR
  cd $DIR
  ln -s utils/.gn


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56419/new/

https://reviews.llvm.org/D56419





More information about the llvm-commits mailing list