[PATCH] D55881: [llvm-objcopy] [COFF] Add support for removing symbols

Mon Jan 7 15:15:08 PST 2019

alexshap accepted this revision.
alexshap added inline comments.

================
Comment at: tools/llvm-objcopy/COFF/Writer.h:25

 class Writer {
 protected:
----------------
mstorsjo wrote:
> alexshap wrote:
> > btw, i forgot to ask it earlier - why do we need this base class + protected fields ?
> > maybe just roll it into COFFWriter ? (the hierarchy of Readers (in ELF and MachO) basically facilitates handling different kinds of input (object file vs binary input (not a regular object file)), but why is this base class necessary ?
> They're not really necessary - I brought them along while copying the general structure from ELF, and I tried to ask for opinions during review whether I should keep or remove them, but I don't think anybody commented on it. I can do an NFC patch to remove them.
yeah, sounds good, thanks

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55881/new/

https://reviews.llvm.org/D55881