[PATCH] D55639: GlobalISel: Allow shift amount to be a different type

[Amara Emerson via Phabricator via llvm-commits]

aemerson added a comment.

Thanks, this definitely needed to be done. Looks mostly fine, but I also can't be confident on the X86 changes. @igorb @aivchenk can you take a look at this change?



================
Comment at: include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h:115
+      if (isInstUnsupported({TargetOpcode::G_SHL, {DstTy, DstTy}}) ||
+          isInstUnsupported({TargetOpcode::G_ASHR, {DstTy, DstTy}}) ||
           isInstUnsupported({TargetOpcode::G_CONSTANT, {DstTy}}))
----------------
Use the SrcTy here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55639/new/

https://reviews.llvm.org/D55639