[PATCH] D55881: [llvm-objcopy] [COFF] Add support for removing symbols

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added inline comments.


================
Comment at: tools/llvm-objcopy/COFF/Object.h:84
+
+  size_t NextSymbolUniqueId = 0;
+
----------------
i was thinking about these 3 guys for some time, 
i don't have a strong opinion - however, for what it's worth, they all should be in some consistent state, maybe there should be an extra abstraction which would encapsulate them ? (and Object would own that abstraction (for example)). There is some interference with relocations, but we can expose some methods to enable that "communication". 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55881/new/

https://reviews.llvm.org/D55881