[PATCH] D56266: [GlobalISel] Fix choice of instruction selector for AArch64 at -O0 with -global-isel=0

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 7 13:21:45 PST 2019


aemerson added a comment.

Thanks for the cleanup. LGTM with minor naming change.



================
Comment at: lib/CodeGen/TargetPassConfig.cpp:760
+  // Determine an instruction selector.
+  enum class Selector { SelectionDAG, FastISel, GlobalISel };
+  Selector selector;
----------------
Minor nit: can we maybe rename Selector->SelectorType and then properly capitalize the 'selector' variable.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56266/new/

https://reviews.llvm.org/D56266





More information about the llvm-commits mailing list