[PATCH] D56141: [asan] Support running without /proc

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis marked an inline comment as done.
eugenis added a comment.

In D56141#1342105 <https://reviews.llvm.org/D56141#1342105>, @krytarowski wrote:

> Can we handle with this change a similar scenario that proc map is too large to be retrieved? If so can we generalize no-/proc to no-memorymap?


Does this look like an error return from internal_sysctl in ReadProcMaps? Sure, we can mock that condition with the same flag.



================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_posix.cc:342
 
+bool ShouldMockFailureToOpen(const char *path) {
+  return common_flags()->test_only_emulate_no_procfs &&
----------------
vitalybuka wrote:
> what if instead of this we add
> common_flags()->procfs_path and set it to /proc/ by defaut?
Not sure about that. It would take a mock flag, and disguise it as a user flag. Unless there are actual practical cases where procfs is mounted somewhere other than /proc, all this would do is confuse people, IMHO.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56141/new/

https://reviews.llvm.org/D56141