[PATCH] D56392: [LLD][COFF] Support /ignore:4099. Support /ignore with comma-separated arguments.

Mon Jan 7 10:48:03 PST 2019

aganea marked an inline comment as done.
aganea added inline comments.

================
Comment at: COFF/PDB.cpp:1306
+      auto FileName = sys::path::filename(Path);
+      warn("Cannot use debug info for '" + FileName + "' [LNK4099]\n" +
+           ">>> failed to load reference " +
----------------
ruiu wrote:
> I don't know if adding `[LNK4099]` is the right thing. We have a lot of warnings and error messages in lld, but no one includes such error code. If we want to do this (I personally don't want though), we should do for everything, but this needs to be discussed first.
This is how other `/ignore` are handled (look for "[LNK4037]" and "[LNK4217]" in `lld/trunk/COFF/Driver.cpp` and `lld/trunk/COFF/SymbolTable.cpp`). This has been discussed in D44297. 

Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56392/new/

https://reviews.llvm.org/D56392